bpo-36381: warn when no PY_SSIZE_T_CLEAN#12473
Merged
Merged
Conversation
We will remove int support from 3.10 or 4.0.
methane
changed the title
eamanu
approved these changes
Mar 20, 2019
vstinner
reviewed
Mar 20, 2019
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
Thanks for your PR. IMHO it's time to deprecate that. Using int in 2019 can lead to bugs, most CPUs are 64-bit.
| Changes in the C API | ||
| -------------------- | ||
|
|
||
| * Use of ``#`` variants of formats without ``PY_SSIZE_T_CLEAN`` defined |
Member
There was a problem hiding this comment.
Hum, it's non obvious that these formats are used to parse function arguments. Maybe mention "ex: PyArg_ParseTuple"?
Member
There was a problem hiding this comment.
I would add references to PyArg_ParseTuple and Py_BuildValue.
Member
There was a problem hiding this comment.
Oh right, I always forget about Py_BuildValue() which is the "opposite" or PyArg_ParseTuple().
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
LGTM, but the What's New entry should be more detailed.
| Changes in the C API | ||
| -------------------- | ||
|
|
||
| * Use of ``#`` variants of formats without ``PY_SSIZE_T_CLEAN`` defined |
Member
There was a problem hiding this comment.
I would add references to PyArg_ParseTuple and Py_BuildValue.
And replace PendingDeprecationWarning with DeprecationWarning.
tacaswell
added a commit
to tacaswell/matplotlib
that referenced
this pull request
Apr 1, 2019
The # variants the PyArg formats will raise deprecation warnings in py38. https://bugs.python.org/issue8677 https://bugs.python.org/issue36381 python/cpython#12473 python/cpython@d3c72a2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We will remove int support from 3.10 or 4.0.
https://bugs.python.org/issue8677